Fix information logs getting logged as debug in VSCode#78522
Fix information logs getting logged as debug in VSCode#78522dibarbet merged 3 commits intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
| /// TODO - Switch this to call LogInformation once appropriate callers have been changed to LogDebug. | ||
| /// </summary> | ||
| public override void LogInformation(string message, params object[] @params) => _hostLogger.LogDebug(message, @params); | ||
| public override void LogInformation(string message, params object[] @params) => _hostLogger.LogInformation(message, @params); |
There was a problem hiding this comment.
we were previously downgrading all info logs to debug in vscode because information logs were too verbose. That was because originally the lowest LSP logger level was info, and we ended up logging everything as info.
this fixes it by logging info as info, and adjusting the usages of info logging to a more appropriate level.
There was a problem hiding this comment.
Oh thank you for finally fixing this!
src/LanguageServer/Protocol/Handler/Completion/CompletionResolveHandler.cs
Show resolved
Hide resolved
| // what to skip, and what files we have to tell the client have been removed. | ||
| var previousResults = GetPreviousResults(diagnosticsParams) ?? []; | ||
| context.TraceInformation($"previousResults.Length={previousResults.Length}"); | ||
| context.TraceDebug($"previousResults.Length={previousResults.Length}"); |
There was a problem hiding this comment.
Not really related to this, but whenever I saw this in the logs it was very unclear what this was related to. Not sure if it should also be prefixed with handlerName or something.
There was a problem hiding this comment.
it already is prefixed by the method name
src/LanguageServer/Protocol/Handler/RelatedDocuments/RelatedDocumentsHandler.cs
Outdated
Show resolved
Hide resolved
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
Updates LSP logging to log using debug more appropriately, and fixes LSP server logging to not downgrade information logs to debug.